Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: TestTransportBodyReadError_Some flake #31260

Open
bradfitz opened this issue Apr 4, 2019 · 3 comments

Comments

@bradfitz
Copy link
Member

@bradfitz bradfitz commented Apr 4, 2019

Saw flake on windows-386-2008 trybot run:
https://storage.googleapis.com/go-build-log/bead3586/windows-386-2008_71f1676b.log

--- FAIL: TestTransportBodyReadError_Some (0.00s)
    transport_test.go:742: server: body: []; expected [49 50 51]
FAIL
FAIL	golang.org/x/net/http2	23.120s
@bradfitz bradfitz added this to the Go1.13 milestone Apr 4, 2019
@bradfitz bradfitz self-assigned this Apr 4, 2019
@bradfitz

This comment has been minimized.

Copy link
Member Author

@bradfitz bradfitz commented May 29, 2019

@euroelessar, you added this test in golang/net@1c5f79c for #27208.

Could you look into this and help deflake the test?

@bradfitz bradfitz removed their assignment Jun 4, 2019
@bradfitz

This comment has been minimized.

Copy link
Member Author

@bradfitz bradfitz commented Jun 7, 2019

Also TestTransportBodyReadError_Immediately flakes:

https://storage.googleapis.com/go-build-log/b23ff2c8/windows-amd64-2016_3f47b07b.log

--- FAIL: TestTransportBodyReadError_Immediately (0.00s)
    transport_test.go:767: server: stream reset count: 0; expected: 1
FAIL
FAIL	golang.org/x/net/http2	13.610s
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 7, 2019

Change https://golang.org/cl/181198 mentions this issue: http2: disable a flaky test on Windows for now, add more logging

gopherbot pushed a commit to golang/net that referenced this issue Jun 7, 2019
Updates golang/go#31260

Change-Id: Icf26461dc48f5f16a91a93df6aa78fec1338f51f
Reviewed-on: https://go-review.googlesource.com/c/net/+/181198
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.