Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: intrinsify math/bits.RotateLeft{32,64} on all architectures #31265

Open
mundaym opened this issue Apr 4, 2019 · 5 comments

Comments

@mundaym
Copy link
Member

commented Apr 4, 2019

#21536 (comment) reminded me about this. Currently the intrinsic is only implemented on amd64, arm64, ppc64 and s390x. We should enable it everywhere. It will need tests in tests/codegen. Could be a good beginner compiler issue to tackle.

CLs so far:

@mundaym mundaym added this to the Unplanned milestone Apr 4, 2019

@josharian

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

cc @benshi001 for arm

@bcmills bcmills added the NeedsFix label Apr 12, 2019

@odeke-em

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Kindly paging @bmkessler who might also be interested in this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 14, 2019

Change https://golang.org/cl/182359 mentions this issue: cmd/compile: intrinsify RotateLeft32 on wasm

@gopherbot

This comment has been minimized.

Copy link

commented Aug 8, 2019

Change https://golang.org/cl/188697 mentions this issue: cmd/compile: optimize ARM's math.bits.RotateLeft32

@gopherbot

This comment has been minimized.

Copy link

commented Aug 8, 2019

Change https://golang.org/cl/189277 mentions this issue: cmd/compile: optimize 386's math.bits.RotateLeft32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.