Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/loader: TestCycles fails on linux/386 Go 1.12 #31279

Closed
bradfitz opened this issue Apr 5, 2019 · 3 comments

Comments

@bradfitz
Copy link
Member

commented Apr 5, 2019

https://build.golang.org/log/df60e921633e8acfbd8f468fbcf41c81dc2c8c6f

cannot find package "nosuchpkg" in any of:
	/workdir/go/src/nosuchpkg (from $GOROOT)
	/workdir/gopath/src/nosuchpkg (from $GOPATH)
cannot find package "nosuchpkg" in any of:
	/workdir/go/src/nosuchpkg (from $GOROOT)
	/workdir/gopath/src/nosuchpkg (from $GOPATH)
open /workdir/gopath/src/golang.org/x/tools/go/loader/missing.go: no such file or directory
open /workdir/gopath/src/golang.org/x/tools/go/loader/missing.go: no such file or directory
/workdir/gopath/src/golang.org/x/tools/go/loader/testdata/badpkgdecl.go:1:34: expected 'package', found 'EOF'
/workdir/gopath/src/golang.org/x/tools/go/loader/testdata/badpkgdecl.go:1:34: expected 'package', found 'EOF'
/go/src/b/x.go:1:21: could not import c (cannot find package "c" in any of:
	/go/src/c (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath'))
/go/src/b/x.go:1:21: could not import c (cannot find package "c" in any of:
	/go/src/c (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath'))
/go/src/b/x.go:1:21: could not import c (/go/src/c/x.go:1:8: expected 'IDENT', found 'EOF')
/go/src/c/x.go:1:20: expected operand, found 'EOF'
cannot find package "two/three" in any of:
	/go/src/two/three (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath')
cannot find package "http" in any of:
	/go/src/vendor/http (vendor tree)
	/go/src/http (from $GOROOT)
	($GOPATH not set. For more details see: 'go help gopath')
/go/src/c/x.go:1:31: cannot convert false (untyped bool constant) to int
--- FAIL: TestCycles (0.00s)
    loader_test.go:746: three-package cycle: Load() errors = ["/go/src/a/x.go:1:21: could not import b (import cycle: a -> b -> c -> a)"], want "import cycle: c -> a -> b -> c"
FAIL
FAIL	golang.org/x/tools/go/loader	9.001s

@bradfitz bradfitz added this to the Go1.13 milestone Apr 5, 2019

@ianthehat

This comment has been minimized.

Copy link

commented Apr 5, 2019

I have seen that one before, but then it just went away on it's own.
My guess is it's a flake because the cycle detection depends on graph walk order and can report a different starting point in the loop.
Over you you Michael

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019

@stamblerre

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

Just saw this again on CL 185995 (logs).

@gopherbot

This comment has been minimized.

Copy link

commented Jul 15, 2019

Change https://golang.org/cl/185984 mentions this issue: go/loader: normalize cycle to remove flake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.