Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/present: Origin mismatch for websocket when using HTTPS. #31328

Open
daved opened this issue Apr 7, 2019 · 2 comments

Comments

@daved
Copy link

commented Apr 7, 2019

What version of Go are you using (go version)?

go version go1.12 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

linux + amd64

What did you do?

Running the present tool with -orighost=present.example.localhost and the reverse proxy ensuring all connections are secure causes the "/socket" request origin to be mismatched.

What did you expect to see?

101 Switching Protocols

What did you see instead?

403 Forbidden

Workaround

If the origin url scheme is swapped out to "https", then the "/socket" request returns 101 as desired.

@gopherbot gopherbot added this to the Unreleased milestone Apr 7, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Apr 7, 2019

Change https://golang.org/cl/171118 mentions this issue: x/tools/cmd/present: fix origin mismatch for websocket when using HTTPS

@gopherbot

This comment has been minimized.

Copy link

commented Apr 16, 2019

Change https://golang.org/cl/170863 mentions this issue: cmd/gopherbot: CC triaged issues to owners

@gopherbot gopherbot added the Tools label Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.