Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: version encoding in GOPROXY indexes (list files) #31339

Open
nim-nim opened this issue Apr 8, 2019 · 0 comments

Comments

@nim-nim
Copy link

commented Apr 8, 2019

goproxy states that

GET $GOPROXY//@v/list returns a list of all known versions of the given module, one per line.

but also, a few lines later, that

To avoid problems when serving from case-sensitive file systems, the module and version elements are case-encoded

That seems to imply that because version is case-encoded in file paths and urls, it is also encoded in lists. However, “seems to imply” is not the same thing as a clear specification, and
rewriteVersionList for example, does not seem to perform any encoding check before writing indexes.

(practically we will need to force lower-casing in the versions we process for other reasons, but the go version spec, unfortunately, is not so strict).

That's one of the many little things that make an official go mod index desirable (issue #31303)

@ALTree ALTree added this to the Unplanned milestone Apr 9, 2019

@andybons andybons changed the title cmd/go version encoding in GOPROXY indexes (list files) cmd/go: version encoding in GOPROXY indexes (list files) May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.