Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: fake command-line-args package isn't created on windows when ad-hoc package file is missing #31344

Open
matloob opened this issue Apr 8, 2019 · 4 comments

Comments

@matloob
Copy link
Contributor

commented Apr 8, 2019

I haven't been able to reproduce this for go list, so I'm setting this as a go/packages bug for now.

It seems like on Windows, when doing a go list -e of an ad-hoc package where a source file doesn't exist, the fake command-line-args package that contains the error isn't created. See the comment on golang.org/x/tools/go/packages.TestErrorMissingFile.

@bcmills

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

@bcmills

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Is this in module mode, GOPATH mode, or both?

@gopherbot

This comment has been minimized.

Copy link

commented Apr 16, 2019

Change https://golang.org/cl/170863 mentions this issue: cmd/gopherbot: CC triaged issues to owners

@matloob matloob changed the title go/packages: fake command-line-args package isn't created on windows when ad-hoc package file is missing x/tools/go/packages: fake command-line-args package isn't created on windows when ad-hoc package file is missing Apr 23, 2019

@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2019

@matloob

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

It looks like this is happening for both.

@gopherbot gopherbot added the Tools label Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.