Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcmd/go: plugin versions do not match when built within vs. outside a module #31354
Comments
|
Bump. Any plans to fix this? Seems that algorithm which verifies package version integrity needs alignment. |
|
This is the same underlying problem as #29814. The workaround should be to build both the plugin and the main binary from outside of their respective repositories, or (as you note) to use a |
bcmills
changed the title
|
CC @jayconrod |
|
See also #31278, of which this may be a duplicate. |
|
There are several similar tickets; apologies if this is not the right place to comment. If the path is different but the version of the libraries are identical, we get version mismatch errors. A way of replicating this is to build the calling program in a container, and build the plugin outside of the container. The paths may look like this: Building locally, and where:
echo $(TZ=UTC git show -s --format=%cd --date=format-local:%Y%m%d%H%M%S HEAD | cut -b -19 | tr -cd '[:digit:]')-$(git rev-parse HEAD | cut -b -12)
# Error:
2:31:33 main.go:485: plugin.Open("dummy"): plugin was built with a different version of package github.com/xxxserxxx/gotop/v3/devices
$ #######################################################
$ strings ./gotop | grep 'v3/devices$'
go.link.pkghashbytes.github.com/xxxserxxx/gotop/v3/devices
go.link.pkghash.github.com/xxxserxxx/gotop/v3/devices
%github.com/xxxserxxx/gotop/v3/devices
go.link.pkghashbytes.github.com/xxxserxxx/gotop/v3/devices
go.link.pkghash.github.com/xxxserxxx/gotop/v3/devices
$ #######################################################
$ strings dummy.so | grep 'v3/devices$'
go.link.pkghashbytes.github.com/xxxserxxx/gotop/v3/devices
go.link.pkghash.github.com/xxxserxxx/gotop/v3/devices
github.com/xxxserxxx/gotop-dummygithub.com/xxxserxxx/gotop-dummygithub.com/xxxserxxx/gotop/v3/devices
%github.com/xxxserxxx/gotop/v3/devices
go.link.pkghashbytes.github.com/xxxserxxx/gotop/v3/devices
go.link.pkghash.github.com/xxxserxxx/gotop/v3/devicesI've played with copying the If I add the following to the plugin's then it works. EditRewrote some of the text to be more readable, I hope. Edit 2I made an error: I need to remove the |
|
Same thing happens for me for a go.mod-based project regarding the |
|
Another data point which I can't even begin to interpret: $ git clone https://github.com/xxxserxxx/gotop
$ git clone https://github.com/xxxserxxx/gotop-dummy
$ cd gotop && git checkout v3.5.0
$ go build -o gotop ./cmd/gotop
$ cd ../gotop-dummy && grep gotop go.mod
require github.com/xxxserxxx/gotop/v3 v3.5.0
$ go mod download
$ go mod vendor
$ go build --buildmode=plugin -o ../gotop/dummy.so .
$ cd ../gotop
$ ./gotop -X dummy # this hangs for some reason; ^C to break
$ cat ~/.local/state/gotop/errors.log
13:03:16 main.go:485: plugin.Open("dummy"): plugin was built with a different version of package github.com/shirou/gopsutil/internal/common
$ go mod graph | grep gopsutil
github.com/xxxserxxx/gotop/v3 github.com/shirou/gopsutil@v2.18.11+incompatible
➜ gotop git:(be42ba5) ✗ git log -1
commit be42ba538cefc892d1dc3d18c783483f4875baff (HEAD, tag: v3.5.0)
$ cd ../gotop-dummy
$ go mod graph | grep gopsutil
github.com/xxxserxxx/gotop/v3@v3.5.0 github.com/shirou/gopsutil@v2.18.11+incompatibleThese are the identical dependencies. Why is the system claiming that they are not? |
|
Still an issue we're running into as well. |
do you mean to say, that the |
|
Has anybody found a way to build reproducible plugins for different machines? |
|
@mytototo There is no reliable way, as the problem is by design. Every dependency of every package used in both plugin and main app have to be exactly the same version, making plugin and app extremely highly coupled. Even if you have control over both, plugin and app, this is very hard or impossible to maintain because you don't have control over what 3rd party modules might import. Unfortunately that means there are very few practical use cases for Go plugins, as far as I can see. |
What did you do?
I have simple application that loads Go plugins and allows them to communicate with app via exported interface.
Simplified version can be found here.
Shared interface is stored under
extdirectory, real implementation is located underplugindirectory.Application passes pointer to real implementation to dynamically loaded plugin which expects interface.
Example plugin code can be found here.
Unfortunately combination of Go Modules and Go Plugins doesn't work unless go.mod of plugins module has
replaceentry with local relative path for shared interface path.When I use remote location in plugins module, application crashes because of wrong version of packages.
Build app:
Then build plugin
When I change plugins go mod to use local path instead of remote one everything works.
What did you expect to see?
Go Modules and plugins working fine when remote path is used.
What did you see instead?
Error about different package versions.
Does this issue reproduce with the latest release (go1.12.3)?
Yes.
System details