os: fix Process.Wait comment (and Windows implementation?)

[alberts]

What steps will reproduce the problem?

os/Process.Wait's comment says:

Wait waits for the Process to exit or stop, and then returns a ProcessState describing
its status and an error, if any.

at http://weekly.golang.org/pkg/os/#Process.Wait but rsc said:

https://groups.google.com/group/golang-dev/msg/cc712d1b2943ee65

According to that thread, the Windows implementation probably needs to change.

Which revision are you using?  (hg identify)

tip

Please provide any additional information below.

[alexbrainman]

Comment 1:

I don't see any problem here. os.Process.Wait indeed waits for process to exit. Please,
provide a small program to demonstrate, if you think otherwise.
If you think that godoc comment is wrong on Windows, tell us what it should say.
Thank you.
Alex

Status changed to WaitingForReply.

[alberts]

Comment 2:

Wait doesn't wait for a process to stop on Linux, so the comment in exec_unix.go is
wrong. I was under the impression that the os package provides the same behaviour across
platforms, so unless Windows behaviour changes, that is no longer the case.

[dsymonds]

Comment 3:

By "stop", I assume you mean with SIGSTOP, after which a process may be resumed with
SIGCONT. Wait should not return upon a SIGSTOP; the comment on the method probably needs
to remove the "or stop" because it leads to this confusion.

Labels changed: added priority-go1, documentation, removed priority-triage.

Status changed to Accepted.

[rsc]

Comment 4:

This issue was closed by revision 30db6d4.

Status changed to Fixed.