Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: fix Process.Wait comment (and Windows implementation?) #3138

Closed
alberts opened this issue Feb 27, 2012 · 4 comments
Closed

os: fix Process.Wait comment (and Windows implementation?) #3138

alberts opened this issue Feb 27, 2012 · 4 comments

Comments

@alberts
Copy link
Contributor

@alberts alberts commented Feb 27, 2012

What steps will reproduce the problem?

os/Process.Wait's comment says:

Wait waits for the Process to exit or stop, and then returns a ProcessState describing
its status and an error, if any.

at http://weekly.golang.org/pkg/os/#Process.Wait but rsc said:

https://groups.google.com/group/golang-dev/msg/cc712d1b2943ee65

According to that thread, the Windows implementation probably needs to change.

Which revision are you using?  (hg identify)

tip

Please provide any additional information below.
@alexbrainman

This comment has been minimized.

Copy link
Member

@alexbrainman alexbrainman commented Feb 27, 2012

Comment 1:

I don't see any problem here. os.Process.Wait indeed waits for process to exit. Please,
provide a small program to demonstrate, if you think otherwise.
If you think that godoc comment is wrong on Windows, tell us what it should say.
Thank you.
Alex

Status changed to WaitingForReply.

@alberts

This comment has been minimized.

Copy link
Contributor Author

@alberts alberts commented Feb 27, 2012

Comment 2:

Wait doesn't wait for a process to stop on Linux, so the comment in exec_unix.go is
wrong. I was under the impression that the os package provides the same behaviour across
platforms, so unless Windows behaviour changes, that is no longer the case.
@dsymonds

This comment has been minimized.

Copy link
Member

@dsymonds dsymonds commented Feb 27, 2012

Comment 3:

By "stop", I assume you mean with SIGSTOP, after which a process may be resumed with
SIGCONT. Wait should not return upon a SIGSTOP; the comment on the method probably needs
to remove the "or stop" because it leads to this confusion.

Labels changed: added priority-go1, documentation, removed priority-triage.

Status changed to Accepted.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Mar 2, 2012

Comment 4:

This issue was closed by revision 30db6d4.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.