Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regexp: improve test coverage #31392

Open
sylvinus opened this issue Apr 10, 2019 · 2 comments
Open

regexp: improve test coverage #31392

sylvinus opened this issue Apr 10, 2019 · 2 comments
Labels
Milestone

Comments

@sylvinus
Copy link
Contributor

@sylvinus sylvinus commented Apr 10, 2019

There are some areas of the regexp module that are not covered by the tests, as extensive as they already are.

Mostly, they include some prefix stuff (that may have caused #30511 & #30425), some utf8 code paths, some case folding, some paths in onepass and the RuneReader input interface.

Does the idea of trying to run all test regexps through all 3 matchers (onepass when possible, backtrack, nfa) and all 3 input types (string, bytes, reader) sound good? We should aim for each of them being individually correct, and this would help adding new ones in the future (dfa!).

I'm starting work on a CL. I want to throw in some of the fuzzing I did before in #21463, should I add it here or open a separate issue/CL?

Thanks!

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 10, 2019

Change https://golang.org/cl/171597 mentions this issue: regexp: improve test coverage

@ALTree ALTree added this to the Unplanned milestone Apr 11, 2019
@ALTree ALTree added the Testing label Apr 11, 2019
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Apr 11, 2019

Fuzzing sounds like a great way to improve test coverage. No need to file a separate issue if you don't want to.

@bcmills bcmills added the NeedsFix label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.