net: TestUnixAndUnixpacketServer flaky on linux

[bcmills]

https://build.golang.org/log/09fce21c31d8c4435fb99a4f7c0e8a1bb2bf900f and
https://build.golang.org/log/faa4560674d8e7d406b7031bfe985db237b9860a:

--- FAIL: TestUnixAndUnixpacketServer (0.00s)
    server_test.go:197: #3: EOF
FAIL
FAIL	net	8.796s

See previously #13205 (CC @bradfitz).

[bradfitz]

/cc @mikioh

[bcmills]

Here's one on linux-amd64-jessie:
https://build.golang.org/log/3845a3972f455aadd7d2a606928e7ba68d8fd2fd

[bcmills]

linux-s390x-ibm: https://build.golang.org/log/895e752f114ea5e0b3e13598c5615957274122a6

[bigmikes]

TestUnixAndUnixpacketServer makes use of transponder function for the echo server. After some investigation I noticed that the test become stable if connection is not closed. I basically commented the below defer c.Close() line.

go/src/net/mockserver_test.go

Lines 222 to 226 in a6a7b14

	return
	}
	defer c.Close()
	network := ln.Addr().Network()

I am not sure why this is happening. In theory the Close should take care of flushing all the data of socket before actually closing it.

Is it possible that for really unlucky cases the connection gets closed before the client is able to read the data?

[bcmills]

linux-amd64-fedora: https://build.golang.org/log/2c48966d096d8f0799059c471d75445fd89f8c1e

[tklauser]

Just seen on linux-amd64 TryBot with https://golang.org/cl/226497 for release-branch.go1.14: https://storage.googleapis.com/go-build-log/17d3b934/linux-amd64_9d353879.log

[bcmills]

2020-04-22T14:14:34-e93d5b5/linux-mips64le-mengzhuo
2020-04-22T11:37:03-a45ea55/linux-mips64le-mengzhuo
2020-04-18T20:01:46-f5291cf/linux-mips64le-mengzhuo
2020-04-08T20:57:26-a036185/linux-mips64le-mengzhuo
2020-02-26T23:27:55-12cd55c/linux-mips64le-mengzhuo
2020-02-24T01:50:28-402ea9e/linux-amd64-sid
2020-01-22T15:24:05-6718cb6/linux-mips64le-mengzhuo
2020-01-09T17:28:58-957259b/linux-386
2019-11-19T19:14:25-8608733/linux-mips64le-mengzhuo
2019-11-05T16:29:31-f0390ff/linux-386-sid
2019-10-28T16:56:52-6afabe2/linux-mips64le-mengzhuo
2019-09-30T15:43:34-5f1aeae/linux-amd64-fedora
2019-06-21T21:02:09-1803ab1/linux-s390x-ibm
2019-05-30T12:01:18-2ae793e/linux-amd64-jessie
2019-05-02T14:44:05-19f5c23/linux-amd64-race