Skip to content

net: TestUnixAndUnixpacketServer flaky on linux #31423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bcmills opened this issue Apr 11, 2019 · 7 comments
Open

net: TestUnixAndUnixpacketServer flaky on linux #31423

bcmills opened this issue Apr 11, 2019 · 7 comments
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 11, 2019 •
edited
Loading

https://build.golang.org/log/09fce21c31d8c4435fb99a4f7c0e8a1bb2bf900f and
https://build.golang.org/log/faa4560674d8e7d406b7031bfe985db237b9860a:

--- FAIL: TestUnixAndUnixpacketServer (0.00s)
    server_test.go:197: #3: EOF
FAIL
FAIL	net	8.796s

See previously #13205 (CC @bradfitz).
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 11, 2019
@bcmills bcmills added this to the Go1.13 milestone Apr 11, 2019
@bcmills bcmills changed the title net: TestUnixAndUnixpacketServer flake on linux-386-clang builder net: TestUnixAndUnixpacketServer flaky on linux-386-clang builder Apr 11, 2019
@bradfitz
Copy link
Contributor

/cc @mikioh

@bradfitz bradfitz added help wanted Testing An issue that has been verified to require only test changes, not just a test failure. labels Apr 11, 2019
@bcmills bcmills changed the title net: TestUnixAndUnixpacketServer flaky on linux-386-clang builder net: TestUnixAndUnixpacketServer flaky on linux May 30, 2019
@bcmills
Copy link
Contributor Author

bcmills commented May 30, 2019

Here's one on linux-amd64-jessie:
https://build.golang.org/log/3845a3972f455aadd7d2a606928e7ba68d8fd2fd

@bcmills
Copy link
Contributor Author

bcmills commented Jun 21, 2019

linux-s390x-ibm: https://build.golang.org/log/895e752f114ea5e0b3e13598c5615957274122a6

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@gmichelo
Copy link
Contributor

gmichelo commented Jul 16, 2019 •
edited
Loading

TestUnixAndUnixpacketServer makes use of transponder function for the echo server. After some investigation I noticed that the test become stable if connection is not closed. I basically commented the below defer c.Close() line.

go/src/net/mockserver_test.go

Lines 222 to 226 in a6a7b14

return
}
defer c.Close()
network := ln.Addr().Network()

I am not sure why this is happening. In theory the Close should take care of flushing all the data of socket before actually closing it.

Is it possible that for really unlucky cases the connection gets closed before the client is able to read the data?

@bcmills
Copy link
Contributor Author

bcmills commented Sep 30, 2019 •
edited
Loading

linux-amd64-fedora: https://build.golang.org/log/2c48966d096d8f0799059c471d75445fd89f8c1e

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@tklauser
Copy link
Member

tklauser commented Mar 30, 2020 •
edited
Loading

Just seen on linux-amd64 TryBot with https://golang.org/cl/226497 for release-branch.go1.14: https://storage.googleapis.com/go-build-log/17d3b934/linux-amd64_9d353879.log

@bcmills
Copy link
Contributor Author

bcmills commented Apr 22, 2020

2020-04-22T14:14:34-e93d5b5/linux-mips64le-mengzhuo
2020-04-22T11:37:03-a45ea55/linux-mips64le-mengzhuo
2020-04-18T20:01:46-f5291cf/linux-mips64le-mengzhuo
2020-04-08T20:57:26-a036185/linux-mips64le-mengzhuo
2020-02-26T23:27:55-12cd55c/linux-mips64le-mengzhuo
2020-02-24T01:50:28-402ea9e/linux-amd64-sid
2020-01-22T15:24:05-6718cb6/linux-mips64le-mengzhuo
2020-01-09T17:28:58-957259b/linux-386
2019-11-19T19:14:25-8608733/linux-mips64le-mengzhuo
2019-11-05T16:29:31-f0390ff/linux-386-sid
2019-10-28T16:56:52-6afabe2/linux-mips64le-mengzhuo
2019-09-30T15:43:34-5f1aeae/linux-amd64-fedora
2019-06-21T21:02:09-1803ab1/linux-s390x-ibm
2019-05-30T12:01:18-2ae793e/linux-amd64-jessie
2019-05-02T14:44:05-19f5c23/linux-amd64-race

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@bradfitz @rsc @andybons @tklauser @bcmills @gmichelo