net: TestUnixAndUnixpacketServer flaky on linux #31423

bcmills · 2019-04-11T19:36:46Z

https://build.golang.org/log/09fce21c31d8c4435fb99a4f7c0e8a1bb2bf900f and
https://build.golang.org/log/faa4560674d8e7d406b7031bfe985db237b9860a:

--- FAIL: TestUnixAndUnixpacketServer (0.00s)
    server_test.go:197: #3: EOF
FAIL
FAIL	net	8.796s

See previously #13205 (CC @bradfitz).

bradfitz · 2019-04-11T19:43:40Z

/cc @mikioh

bcmills · 2019-05-30T13:01:26Z

Here's one on linux-amd64-jessie:
https://build.golang.org/log/3845a3972f455aadd7d2a606928e7ba68d8fd2fd

bcmills · 2019-06-21T22:28:27Z

linux-s390x-ibm: https://build.golang.org/log/895e752f114ea5e0b3e13598c5615957274122a6

bigmikes · 2019-07-16T14:32:12Z

TestUnixAndUnixpacketServer makes use of transponder function for the echo server. After some investigation I noticed that the test become stable if connection is not closed. I basically commented the below defer c.Close() line.

go/src/net/mockserver_test.go

Lines 222 to 226 in a6a7b14

    
           	return 
        
           } 
        
           defer c.Close() 
        
           network := ln.Addr().Network()

I am not sure why this is happening. In theory the Close should take care of flushing all the data of socket before actually closing it.

Is it possible that for really unlucky cases the connection gets closed before the client is able to read the data?

bcmills · 2019-09-30T19:27:29Z

linux-amd64-fedora: https://build.golang.org/log/2c48966d096d8f0799059c471d75445fd89f8c1e

tklauser · 2020-03-30T20:23:58Z

Just seen on linux-amd64 TryBot with https://golang.org/cl/226497 for release-branch.go1.14: https://storage.googleapis.com/go-build-log/17d3b934/linux-amd64_9d353879.log

bcmills · 2020-04-22T15:49:24Z

bcmills added the NeedsInvestigation label Apr 11, 2019

bcmills added this to the Go1.13 milestone Apr 11, 2019

bcmills changed the title ~~net: TestUnixAndUnixpacketServer flake on linux-386-clang builder~~ net: TestUnixAndUnixpacketServer flaky on linux-386-clang builder Apr 11, 2019

bradfitz added help wanted Testing labels Apr 11, 2019

bcmills changed the title ~~net: TestUnixAndUnixpacketServer flaky on linux-386-clang builder~~ net: TestUnixAndUnixpacketServer flaky on linux May 30, 2019

andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019

rsc modified the milestones: Go1.14, Backlog Oct 9, 2019

golang / go

net: TestUnixAndUnixpacketServer flaky on linux #31423

net: TestUnixAndUnixpacketServer flaky on linux #31423

bcmills commented Apr 11, 2019 •

edited

bradfitz commented Apr 11, 2019

bcmills commented May 30, 2019

bcmills commented Jun 21, 2019

bigmikes commented Jul 16, 2019 •

edited

bcmills commented Sep 30, 2019 •

edited

tklauser commented Mar 30, 2020 •

edited

bcmills commented Apr 22, 2020

golang / go

Join GitHub today

net: TestUnixAndUnixpacketServer flaky on linux #31423

net: TestUnixAndUnixpacketServer flaky on linux #31423

Comments

bcmills commented Apr 11, 2019 • edited

bradfitz commented Apr 11, 2019

bcmills commented May 30, 2019

bcmills commented Jun 21, 2019

bigmikes commented Jul 16, 2019 • edited

bcmills commented Sep 30, 2019 • edited

tklauser commented Mar 30, 2020 • edited

bcmills commented Apr 22, 2020

bcmills commented Apr 11, 2019 •

edited

bigmikes commented Jul 16, 2019 •

edited

bcmills commented Sep 30, 2019 •

edited

tklauser commented Mar 30, 2020 •

edited