Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv4: breakage on AIX w/ Go 1.12 #31564

Closed
mikioh opened this issue Apr 19, 2019 · 4 comments
Closed

x/net/ipv4: breakage on AIX w/ Go 1.12 #31564

mikioh opened this issue Apr 19, 2019 · 4 comments
Labels
FrozenDueToAge OS-AIX WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Apr 19, 2019

See https://build.golang.org/log/4cbfc515ce608f590e992c80faa2c06454479f2f

# golang.org/x/net/ipv4 [golang.org/x/net/bpf.test]
ipv4/control_bsd.go:33:49: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:34:16: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:38:12: undefined: syscall.SockaddrDatalink
ipv4/sys_aix.go:22:32: undefined: syscall.SizeofSockaddrDatalink
# golang.org/x/net/ipv4
ipv4/control_bsd.go:33:49: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:34:16: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:38:12: undefined: syscall.SockaddrDatalink
ipv4/sys_aix.go:22:32: undefined: syscall.SizeofSockaddrDatalink
# golang.org/x/net/ipv4 [golang.org/x/net/ipv4.test]
ipv4/control_bsd.go:33:49: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:34:16: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:38:12: undefined: syscall.SockaddrDatalink
ipv4/sys_aix.go:22:32: undefined: syscall.SizeofSockaddrDatalink
FAIL	golang.org/x/net/bpf [build failed]

/cc @Helflym

If no one has no time for care, will sweep this during the Go 1.13 code freeze.

@mikioh mikioh added the OS-AIX label Apr 19, 2019
@mikioh mikioh added this to the Go1.13 milestone Apr 19, 2019
@Helflym
Copy link
Contributor

@Helflym Helflym commented Apr 19, 2019

This is already fixed in master (cf https://go-review.googlesource.com/c/go/+/170537). But as it haven't been backported to 1.12, x/net will always fail on AIX with 1.12. It doesn't really matter as my aim is to have all x/ packages working for 1.13.

@bradfitz it's possible to disable x/net for AIX 1.12 in the builder or that's too complicated and we just let it fail ?

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 19, 2019

@Helflym, I sent https://go-review.googlesource.com/c/build/+/172878 for that. Reviews welcome.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 28, 2019

@bradfitz can this issue be closed now that CL 172878 is merged?

@julieqiu julieqiu added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 28, 2019
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 28, 2019

Yup

@golang golang locked and limited conversation to collaborators May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge OS-AIX WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

5 participants