Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv4: breakage on AIX w/ Go 1.12 #31564

Open
mikioh opened this issue Apr 19, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@mikioh
Copy link
Contributor

commented Apr 19, 2019

See https://build.golang.org/log/4cbfc515ce608f590e992c80faa2c06454479f2f

# golang.org/x/net/ipv4 [golang.org/x/net/bpf.test]
ipv4/control_bsd.go:33:49: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:34:16: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:38:12: undefined: syscall.SockaddrDatalink
ipv4/sys_aix.go:22:32: undefined: syscall.SizeofSockaddrDatalink
# golang.org/x/net/ipv4
ipv4/control_bsd.go:33:49: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:34:16: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:38:12: undefined: syscall.SockaddrDatalink
ipv4/sys_aix.go:22:32: undefined: syscall.SizeofSockaddrDatalink
# golang.org/x/net/ipv4 [golang.org/x/net/ipv4.test]
ipv4/control_bsd.go:33:49: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:34:16: undefined: syscall.SizeofSockaddrDatalink
ipv4/control_bsd.go:38:12: undefined: syscall.SockaddrDatalink
ipv4/sys_aix.go:22:32: undefined: syscall.SizeofSockaddrDatalink
FAIL	golang.org/x/net/bpf [build failed]

/cc @Helflym

If no one has no time for care, will sweep this during the Go 1.13 code freeze.

@mikioh mikioh added the OS-AIX label Apr 19, 2019

@mikioh mikioh added this to the Go1.13 milestone Apr 19, 2019

@Helflym

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

This is already fixed in master (cf https://go-review.googlesource.com/c/go/+/170537). But as it haven't been backported to 1.12, x/net will always fail on AIX with 1.12. It doesn't really matter as my aim is to have all x/ packages working for 1.13.

@bradfitz it's possible to disable x/net for AIX 1.12 in the builder or that's too complicated and we just let it fail ?

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.