Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: modules discarded during resolution should not be added to go.sum #31580

Open
rsc opened this issue Apr 20, 2019 · 2 comments
Open

cmd/go: modules discarded during resolution should not be added to go.sum #31580

rsc opened this issue Apr 20, 2019 · 2 comments

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Apr 20, 2019

If I put a bad import into a program and run "go build",
then it looks in various modules for the import,
none of which work, but all of which end up in go.sum.
They should not.

@rsc rsc added this to the Go1.13 milestone Apr 20, 2019
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 28, 2019

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@bcmills bcmills changed the title cmd/go: failed import resolution should not update go.sum cmd/go: modules discarded during resolution should not be added to go.sum Nov 6, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 8, 2020

Change https://golang.org/cl/237017 mentions this issue: cmd/go: don't save sums for modules loaded for import resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.