Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: share cache between views #31589

Closed
stamblerre opened this issue Apr 20, 2019 · 2 comments
Closed

x/tools/gopls: share cache between views #31589

stamblerre opened this issue Apr 20, 2019 · 2 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 20, 2019

@ianthehat

This comment has been minimized.

Copy link

@ianthehat ianthehat commented Apr 21, 2019

I was looking at this the other day, in the context of wanting to improve the client server support, mostly for command line usage.
The trouble is that you end up needing some very complicated garbage collection like logic to evict things that are not needed from the cache, and you also want it to be lazy not precise, as closing a view and then immediately making a new view that wants the same information becomes a common pattern.
This means it is going to take a well thought out design.

@stamblerre stamblerre changed the title x/tools/cmd/gopls: share cache between views x/tools/gopls: share cache between views Jul 2, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Oct 3, 2019

I think this can be closed as of CL 198317.

@stamblerre stamblerre closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.