Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "go mod vendor" should not modify my go.mod file. #31612

Open
andyliuliming opened this issue Apr 22, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@andyliuliming
Copy link

commented Apr 22, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.4 darwin/amd64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/andy/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/andy/workspace/gopath"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12.4/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/andy/workspace/gopath/src/goms.io/acsrp/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/cg/3770ch_93sj65nvnr6t4rbtm0000gn/T/go-build638280199=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

What did you expect to see?

What did you see instead?

@julieqiu julieqiu added this to the Go1.13 milestone Apr 22, 2019

@julieqiu

This comment has been minimized.

Copy link

commented Apr 22, 2019

@jayconrod

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

@andyliuliming What modifications are you seeing?

Most commands will modify the go.mod file if the module graph is not fully specified. These modifications are important for ensuring a reproducible build (and in this case, a reproducible vendor directory).

Did you run go mod tidy before go mod vendor? If there was an unexpected modification, please provide enough information for us to reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.