Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: suspicious symbol generation for args_stackmap #31615

Open
mdempsky opened this issue Apr 22, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@mdempsky
Copy link
Member

commented Apr 22, 2019

In CL 171464, @randall77 fixed a lookup(fmt.Sprintf(...)) call in pgen.go, but we noticed another similarly suspicious line of code for generating args_stackmap symbols. However, Keith reports that applying the same fix didn't work: https://go-review.googlesource.com/c/go/+/171464/1/src/cmd/compile/internal/gc/pgen.go#39

Seems worth looking into and understanding whether the existing code is safe.

@mdempsky mdempsky added this to the Unplanned milestone Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.