Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
context: decide whether to keep Context.String format change #31620
CL 169080 was made with the goal of making
With Go 1.12.4:
With Go tip (e40dffe):
This was brought up in a code review comment and Brad said "let's revisit this".
This issue is about making that decision for 1.13. /cc @bradfitz
If I remember correctly,
That means test should not depend on it, but if they do, they need to be ready to be updated. Once a decision here is made, it'll be possible to know how those tests should be updated for 1.13.
Answered with more detail in a direct message, but to summarize: my findings show very few such tests.
It's also worth pointing out that there is no
I'm also curious the extent of the test failures.
I'd like to do (1) if possible, but (2) is an option if we need it.
I suppose option (3) is just fix all the tests, but that's likely more work for us & users if the breakage is widespread.