Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: TryBots should check go.mod files are tidy #31640
CL 172972 added a dependency on
There's nothing wrong with this dependency, but it should have been more noticeable during code review. If unexpected requirement were added to go.mod, human reviewers would see it.
TryBots should report an error if go.mod and go.sum change with
Is there a flag to
Because we're increasingly blocking outbound network access on builders.
But we do allow GOPROXY access, which we set, so if it needs that, I suppose that's okay.
There's not a simple way to do that, but it's a common feature request we should implement. I'm sure there is an issue filed somewhere.