x/build: TryBots should check go.mod files are tidy #31640
Comments
Is there a flag to Because we're increasingly blocking outbound network access on builders. But we do allow GOPROXY access, which we set, so if it needs that, I suppose that's okay. |
There's not a simple way to do that, but it's a common feature request we should implement. I'm sure there is an issue filed somewhere.
|
If that's on the way, I'd rather wait for that. Cross-reference the two bugs when you find it? |
#27005 would add a I don't think we'll have time to implement it before the freeze though. |
Note that |
CL 172972 added a dependency on
golang.org/x/sync
ingolang.org/x/tools
. The go.mod and go.sum files were not updated.There's nothing wrong with this dependency, but it should have been more noticeable during code review. If unexpected requirement were added to go.mod, human reviewers would see it.
TryBots should report an error if go.mod and go.sum change with
go mod tidy
. This will make sure dependency changes are explicit, and it will keep builds deterministic.The text was updated successfully, but these errors were encountered: