Skip to content

x/build: TryBots should check go.mod files are tidy #31640

Open
@jayconrod

Description

@jayconrod

CL 172972 added a dependency on golang.org/x/sync in golang.org/x/tools. The go.mod and go.sum files were not updated.

There's nothing wrong with this dependency, but it should have been more noticeable during code review. If unexpected requirement were added to go.mod, human reviewers would see it.

TryBots should report an error if go.mod and go.sum change with go mod tidy. This will make sure dependency changes are explicit, and it will keep builds deterministic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.modules

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions