Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: assignReviewersToCLs fails to assign reviewers on CL 173018 #31663

Open
dmitshur opened this issue Apr 24, 2019 · 0 comments

Comments

@dmitshur
Copy link
Member

commented Apr 24, 2019

From gopherbot logs:

2019/04/24 20:58:01 No reviewers or cc: https://go-review.googlesource.com/c/crypto/+/173018
2019/04/24 20:58:01 Setting review on https://go-review.googlesource.com/c/crypto/+/173018: {Message: Labels:map[] Comments:map[
] Reviewers:[{Reviewer:6195@62eb7196-b449-3ce5-99f1-c037f21e1705 State:} {Reviewer:agl@golang.org State:CC}]}
2019/04/24 20:58:01 Could not set review for change "crypto~173018": HTTP status 400 Bad Request; )]}'
{
  "reviewers": {
    "6195@62eb7196-b449-3ce5-99f1-c037f21e1705": {
      "input": "6195@62eb7196-b449-3ce5-99f1-c037f21e1705",
      "error": "Account \u00276195@62eb7196-b449-3ce5-99f1-c037f21e1705\u0027 not found\n6195@62eb7196-b449-3ce5-99f1-c037f21e17
05 does not identify a registered user or group"
    },
    "agl@golang.org": {
      "input": "agl@golang.org"
    }
  },
  "error": "error adding reviewer"
}

Something's went wrong there. 6195 is a valid Gerrit account ID, it's @FiloSottile. Maybe the format wasn't right. Needs investigation.

This contributes to #28320.

/cc @FiloSottile @andybons @bradfitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.