Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/relnote: look for RELNOTEs in commit messages, too #31665

cespare opened this issue Apr 24, 2019 · 2 comments


Copy link

commented Apr 24, 2019

Instead of having to leave a RELNOTE=yes comment immediately after opening a CL, it would be handy to just put that in the body of the commit message.

This feature is so convenient that many people are already using it even though it doesn't exist.

$ git log --format='format:%h / %an / %cI / %s' --grep 'RELNOTE='
8515d9cf65 / Keith Randall / 2019-04-23T17:58:12+00:00 / runtime: randomize package initialization order in race mode
996a687ebb / Matthew Dempsky / 2019-04-16T18:25:24+00:00 / cmd/compile: enable -newescape by default
9da6530faa / Keith Randall / 2019-04-03T21:27:05+00:00 / syscall: avoid _getdirentries64 on darwin
a7fc71092d / Bryan C. Mills / 2019-04-01T16:37:07+00:00 / cmd/go/internal/modget: support the suffix '@patch' in 'go get'
7b916243d9 / Keith Randall / 2019-03-18T20:41:12+00:00 / cmd/compile: rename init function from init.ializers back to init
34fb5855eb / Robert Griesemer / 2019-02-20T20:23:28+00:00 / text/scanner: don't liberally consume (invalid) floats or underbars
d50390ce72 / Elias Naur / 2018-12-15T19:27:41+00:00 / cmd/fix,cmd/cgo,misc/cgo: map the EGLDisplay C type to uintptr in Go
d6c12ec0ef / Bryan C. Mills / 2018-12-06T20:31:50+00:00 / cmd/go/internal/modload: use replacements to resolve missing imports
cdbd4d49d8 / Bryan C. Mills / 2018-11-29T18:57:53+00:00 / cmd/go: enable module mode without a main module when GO111MODULE=on
04e12a5bfa / Bryan C. Mills / 2018-11-29T18:49:31+00:00 / cmd/go/internal/modfetch: lock files and directories
0c7762cd18 / Keith Randall / 2018-11-14T21:01:36+00:00 / cmd/compile: assume unsafe pointer arithmetic generates non-nil results
36aa2b036d / Keith Randall / 2017-12-08T16:13:14+00:00 / cmd/cgo: make JNI's jobject type map to uintptr in Go
b868616b63 / Keith Randall / 2017-11-17T22:11:03+00:00 / cmd/cgo: special case C ptr types to use uintptr
b74f01d76f / Heschi Kreinick / 2017-05-26T21:29:21+00:00 / cmd/internal/dwarf: update to DWARF4, emit frame_base

(This is similar to what we did for R= already in #16431.)

@gopherbot gopherbot added this to the Unreleased milestone Apr 24, 2019

@gopherbot gopherbot added the Builders label Apr 24, 2019

@cespare cespare modified the milestones: Unreleased, Go1.13 May 1, 2019


This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

/cc @dmitshur


This comment has been minimized.

Copy link

commented Jun 11, 2019

It seems like this is already done.

func clRelNote(cl *maintner.GerritCL) string {
	msg := cl.Commit.Msg
	if strings.Contains(msg, "RELNOTE") {
		return parseRelNote(msg)
	for _, comment := range cl.Messages {
		if strings.Contains(comment.Message, "RELNOTE") {
			return parseRelNote(comment.Message)
	return ""

Or am I misunderstand something?

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.