Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: net: export isDomainName #31671

Open
chet opened this issue Apr 25, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@chet
Copy link

commented Apr 25, 2019

I'd like to essentially re-open #2880 for consideration.

The motivating factor here is I have yet to find a good canonical piece of code which callers can leverage to validate an input name against RFC 1035. Searching around for such code yields a whole world of regexes people have come up with that don't fully implement the spec. net.isDomainName may not be perfect either (see: #17659), but it would do a better job that what I'm finding out there otherwise (and be faster).

The original issue got kicked around a lot and eventually closed, so I'm hoping for some feedback one way or the other this time around.

Thanks!

@odeke-em odeke-em changed the title net: isDomainName should be exported proposal: net: export isDomainName Apr 25, 2019

@gopherbot gopherbot added this to the Proposal milestone Apr 25, 2019

@gopherbot gopherbot added the Proposal label Apr 25, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

We definitely don't want to do this while all the questions from #17659 remain unanswered. Otherwise how would we document this function?

@chet

This comment has been minimized.

Copy link
Author

commented Apr 25, 2019

@bradfitz Definitely. My main hope is a decision to this proposal can be made, one way or another. If a decision is made in favor of the proposal, I agree this needs to remain open until #17659 is resolved, and then go from there.

@rsc

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Putting this proposal on hold until at least #17659 is resolved.

@rsc rsc added the Proposal-Hold label May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.