Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: high-percentile latency of memory allocations has regressed significantly [1.12 backport] #31679

Closed
gopherbot opened this issue Apr 25, 2019 · 3 comments
Closed

runtime: high-percentile latency of memory allocations has regressed significantly [1.12 backport] #31679

gopherbot opened this issue Apr 25, 2019 · 3 comments
Assignees
@mknyszek
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.12.5

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 25, 2019

@mknyszek requested issue #31678 to be considered for backport to the next 1.12 minor release.

@gopherbot please backport open a backport to 1.12. I think it makes sense to fix this issue for Go 1.12 since it would at least let users safely move to Go 1.12 without having to skip a release due to performance issues.

We should do more in the future to ensure that performance regressions like this get discovered prior to release as opposed to after, perhaps through improved benchmarks.
@gopherbot gopherbot mentioned this issue Apr 25, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.5 milestone Apr 25, 2019
@mknyszek mknyszek self-assigned this Apr 25, 2019
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 26, 2019

Change https://golang.org/cl/174102 mentions this issue: Revert "runtime: scavenge memory upon allocating from scavenged memory"
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 29, 2019

Closed by merging fd36763 to release-branch.go1.12.
@gopherbot gopherbot closed this Apr 29, 2019
gopherbot pushed a commit that referenced this issue Apr 29, 2019
@mknyszek @bradfitz
Revert "runtime: scavenge memory upon allocating from scavenged memory"
fd36763 
This reverts commit 8e093e7
(CL 159500).

Reason for revert: Increases memory allocation latency in certain
situations.

Fixes #31679.

Change-Id: I15e02c53a58009fd907b619b8649de2cdeb29ef0
Reviewed-on: https://go-review.googlesource.com/c/go/+/174102
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Austin Clements <austin@google.com>
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Apr 29, 2019

Marking as cherry-pick approved because @bradfitz landed the fix on the go1.12 release branch.
@simonpasquier simonpasquier mentioned this issue May 7, 2019
Merged
@golang golang locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mknyszek mknyszek

Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
Go1.12.5
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@mknyszek @gopherbot
You can’t perform that action at this time.