Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: add unkeyed field literal check to 'go test' set #31695

Open
rsc opened this issue Apr 26, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@rsc
Copy link
Contributor

commented Apr 26, 2019

#2794 proposes requiring keyed (tagged) literals for any imported struct.
go vet has a test for this already.
But the test is only on in go vet not the automatic vet during go test.
I suggest we enable it during go test at the start of the Go 1.14 cycle
as an experiment. If it works well there then maybe it would make sense
to promote the restriction to the language itself. And if not, then not.
Or maybe vet alone will be enough. Time will tell.

/cc @robpike @ianlancetaylor @griesemer

@rsc rsc added this to the Go1.14 milestone Apr 26, 2019

@rsc rsc self-assigned this Apr 26, 2019

@rsc rsc added the early-in-cycle label Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.