Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: examples need improvement #31716

Open
FiloSottile opened this issue Apr 27, 2019 · 3 comments

Comments

@FiloSottile
Copy link
Member

commented Apr 27, 2019

There is a total of 4 examples in the package. Two are for New, one doesn't use the package at all, and one incorrectly uses As by dropping the error on the floor if it's not a os.PathError.

	_, err := os.Open("non-existing")
	if err != nil {
		var pathError *os.PathError
		if errors.As(err, &pathError) {
			fmt.Println("Failed at path:", pathError.Path)
		}
	}

@FiloSottile FiloSottile added this to the Go1.13 milestone Apr 27, 2019

@corona10

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@FiloSottile Can I take a look at this issue?

@gopherbot

This comment has been minimized.

Copy link

commented May 4, 2019

Change https://golang.org/cl/175257 mentions this issue: errors: Add errors.Is examples

@gopherbot

This comment has been minimized.

Copy link

commented May 31, 2019

Change https://golang.org/cl/179737 mentions this issue: errors: fix package example

gopherbot pushed a commit that referenced this issue Jun 3, 2019
errors: fix package example
The example in example_test.go requires that the whole file be
displayed; the addition of ExampleAs meant that only the body of the
package example function was shown, rather than the surrounding context.

This change moves ExampleAs to the file wrap_test.go file, restoring the
package example to its former glory.

Update #31716

Change-Id: Id0ea77bc06023b239a63c1d6a7c8b3c1dae91ce9
Reviewed-on: https://go-review.googlesource.com/c/go/+/179737
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Jean de Klerk <deklerk@google.com>
Run-TryBot: Benny Siegert <bsiegert@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.