Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/gopls: allow user fine-grained control over which vet checks to run #31717

Closed
inliquid opened this issue Apr 27, 2019 · 6 comments
Closed

Comments

@inliquid
Copy link

@inliquid inliquid commented Apr 27, 2019

For example, I need to pass -composites=false flag to avoid these meaningless messages:
изображение

@gopherbot gopherbot added this to the Unreleased milestone Apr 27, 2019
@gopherbot gopherbot added the gopls label Apr 27, 2019
@stamblerre stamblerre changed the title x/tools/cmd/gopls: make embedded go vet consume additional params x/tools/cmd/gopls: allow user fine-grained control over which vet checks to run Apr 29, 2019
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 29, 2019

@KatamariJr
Copy link

@KatamariJr KatamariJr commented May 30, 2019

Any update on this? I would also like this feature for the exact same reason.

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 31, 2019

This hasn't been a high priority issue for us yet, but if someone wants to take a look at adding it before I have a chance to, we'd be happy to take contributions.

@guiguan
Copy link

@guiguan guiguan commented Jun 1, 2019

I think this is pretty critical to the developer experience of gopls. I wish I had time to make a contribution

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 1, 2019

Change https://golang.org/cl/179920 mentions this issue: internal/lsp: allow fine-grained control over vet checks

@guiguan
Copy link

@guiguan guiguan commented Jun 5, 2019

A simple workaround to config vet. For example, disable the composite analyzer for github.com/mongodb/mongo-go-driver: guiguan/tools@a9ca269

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.