Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upx/build: add macOS 10.14 386 builder #31719
Comments
This comment has been minimized.
This comment has been minimized.
|
We have limited Macs so we're not going to run every macOS version on amd64 and 386. Mac 32-bit is already a weird case, as its days are probably numbered from Apple and nobody has 32-bit Mac hardware or OSes anyway. The only reason we have darwin/386 at all is to enable hacking on the 386 backend on a Mac. Are you saying that we broke darwin/386 on macOS 10.14 but not on macOS 10.11 where we do run a 386 builder already? |
This comment has been minimized.
This comment has been minimized.
|
Indeed, 1.11 and 1.12 work, but 1.14 doesn't. If we have limited resources, it probably makes sense to make our darwin/386 builder match what our developers use. That's probably the latest supported OS (I'm still on 1.12, but I've got weird hardware reasons to stay.) |
This comment has been minimized.
This comment has been minimized.
|
SGTM. I'll update it. |
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/174319 mentions this issue: |
While working on https://go-review.googlesource.com/c/go/+/174199, I noticed that GOARCH=386 ./all.bash had been broken for a while. This issue is about adding a 10.14 386 builder to avoid that problem in the future.