Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add macOS 10.14 386 builder #31719

Closed
eliasnaur opened this issue Apr 27, 2019 · 4 comments
Closed

x/build: add macOS 10.14 386 builder #31719

eliasnaur opened this issue Apr 27, 2019 · 4 comments

Comments

@eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented Apr 27, 2019

While working on https://go-review.googlesource.com/c/go/+/174199, I noticed that GOARCH=386 ./all.bash had been broken for a while. This issue is about adding a 10.14 386 builder to avoid that problem in the future.

@gopherbot gopherbot added this to the Unreleased milestone Apr 27, 2019
@gopherbot gopherbot added the Builders label Apr 27, 2019
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 29, 2019

We have limited Macs so we're not going to run every macOS version on amd64 and 386. Mac 32-bit is already a weird case, as its days are probably numbered from Apple and nobody has 32-bit Mac hardware or OSes anyway. The only reason we have darwin/386 at all is to enable hacking on the 386 backend on a Mac.

Are you saying that we broke darwin/386 on macOS 10.14 but not on macOS 10.11 where we do run a 386 builder already?

@randall77
Copy link
Contributor

@randall77 randall77 commented Apr 29, 2019

Indeed, 1.11 and 1.12 work, but 1.14 doesn't.

If we have limited resources, it probably makes sense to make our darwin/386 builder match what our developers use. That's probably the latest supported OS (I'm still on 1.12, but I've got weird hardware reasons to stay.)

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 29, 2019

SGTM. I'll update it.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 29, 2019

Change https://golang.org/cl/174319 mentions this issue: dashboard: test darwin/386 on macOS 10.14

@bradfitz bradfitz self-assigned this Apr 29, 2019
@golang golang locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.