Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/lockedfile: use F_OFD_SETLK on Illumos #31765

Open
bcmills opened this issue Apr 30, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@bcmills
Copy link
Member

commented Apr 30, 2019

See the TODO here:

// TODO(bcmills): If we add a build tag for Illumos (see golang.org/issue/20603)
// then Illumos should use F_OFD_SETLK, and the resulting code would be as
// simple as filelock_unix.go. We will still need the code in this file for AIX
// or as long as Oracle Solaris provides only F_SETLK.

The illumos tag was added in https://golang.org/cl/174457 (for #20603), so the TODO can now be done. It should be pretty straightforward.

CC @jclulow @jayconrod @bradfitz

@bcmills bcmills added this to the Go1.14 milestone Apr 30, 2019

@jclulow

This comment has been minimized.

Copy link

commented Apr 30, 2019

Can we add an OS-illumos label for issues like this one?

@bradfitz bradfitz added the OS-illumos label Apr 30, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@jclulow, done.

@bradfitz bradfitz removed the OS-Solaris label Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.