Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/lockedfile: use F_OFD_SETLK on Illumos #31765

Closed
bcmills opened this issue Apr 30, 2019 · 3 comments
Closed

cmd/go/internal/lockedfile: use F_OFD_SETLK on Illumos #31765

bcmills opened this issue Apr 30, 2019 · 3 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Apr 30, 2019

See the TODO here:

// TODO(bcmills): If we add a build tag for Illumos (see golang.org/issue/20603)
// then Illumos should use F_OFD_SETLK, and the resulting code would be as
// simple as filelock_unix.go. We will still need the code in this file for AIX
// or as long as Oracle Solaris provides only F_SETLK.

The illumos tag was added in https://golang.org/cl/174457 (for #20603), so the TODO can now be done. It should be pretty straightforward.

CC @jclulow @jayconrod @bradfitz

@jclulow
Copy link
Contributor

@jclulow jclulow commented Apr 30, 2019

Can we add an OS-illumos label for issues like this one?

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 30, 2019

@jclulow, done.

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@bcmills
Copy link
Member Author

@bcmills bcmills commented Dec 3, 2020

Fixed in CL 255258.

@bcmills bcmills closed this Dec 3, 2020
@bcmills bcmills modified the milestones: Backlog, Go1.16 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants