Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: longtest builder failing on TestNexting/gdb-opt-hist #31786
After CL 174617, the longtest builder is failing on TestNexting/gdb-opt-hist.
When I compile src/cmd/compile/internal/ssa/testdata/hist.go both before and after this change, with both -S and -S=2, I don't see any line number differences. This is the extent of the difference of the -S output:
This difference is part of the
@dr2chase , any ideas?
Working on it...
Redo good and bad compilations prepending GOSSAFUNC=test to both of them.
Also compare dwarfdump -debug-line for both, search forward for testdata:
It works okay with delve, I am still searching through the ssa output to see where the difference appears. It's in blocks 17 and 19, v264 and v275.
edit: The problem is in the original assignment of statement marks (numberlines).
This does not repair #31786, and in fact also unfixes the revert of CL 174617. We were just getting lucky when it looked like it was working. And unfortunately for the bug, there does not appear to be any particular problems with the line numbers; if anything they're a couple of extras, i.e., stepping might repeat, rather than skip. Delve works fine either way. Updates #31786. Change-Id: I5c2fdc2a0265bb99773b3a85492a3db557dffee4 Reviewed-on: https://go-review.googlesource.com/c/go/+/174948 Run-TryBot: David Chase <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Keith Randall <email@example.com>