Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: do we need the equivalent of a cmd/compile -lang flag? #31793

Open
griesemer opened this issue May 2, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@griesemer
Copy link
Contributor

commented May 2, 2019

go/types accepts the latest language spec. The compiler (cmd/compile) has a -lang flag to control the accepted language. Specifically, with -lang=go1.12, the new language features introduced with Go 1.13 are not supported. See #31747 .

Do we need an equivalent "flag" (Config field) to control the accepted language by go/types?

cc: @rsc

@griesemer griesemer added this to the Go1.13 milestone May 2, 2019

@griesemer

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

If we remove such a configuration flag, we can enable the test "issue31747.go" (in go/types/stdlib_test.go) again. See CL https://golang.org/cl/174897.

@andybons andybons added NeedsFix and removed NeedsDecision labels May 14, 2019

@andybons andybons assigned andybons and griesemer and unassigned andybons May 14, 2019

@griesemer griesemer modified the milestones: Go1.13, Go1.14 May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.