Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: have DefaultTransport support all_proxy (SOCKS5) by default #31813

Open
bradfitz opened this issue May 2, 2019 · 2 comments
Open

net/http: have DefaultTransport support all_proxy (SOCKS5) by default #31813

bradfitz opened this issue May 2, 2019 · 2 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 2, 2019

Now that https://go-review.googlesource.com/c/net/+/168921 is in, we have good context support for doing SOCKS5 dials in x/net/proxy.

We should use it from net/http.DefaultTransport so the $ALL_PROXY (and $all_proxy) environment variable lets users configure SOCKS5.

@gopherbot
Copy link

@gopherbot gopherbot commented May 2, 2019

Change https://golang.org/cl/175100 mentions this issue: proxy: add ProxyFromEnvironmentUsing

gopherbot pushed a commit to golang/net that referenced this issue May 3, 2019
Updates golang/go#31813

Change-Id: Ic05fcdb5881c9e01967697542228224611b7a73f
Reviewed-on: https://go-review.googlesource.com/c/net/+/175100
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jacob Blain Christen <dweomer5@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bcmills
Copy link
Member

@bcmills bcmills commented May 20, 2019

@bradfitz, do you intend to implement this yourself for 1.14? (What milestone should it be set at?)

@bcmills bcmills added this to the Unplanned milestone May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.