Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: support internal linking for Android and iOS #31819

Open
eliasnaur opened this issue May 3, 2019 · 2 comments
Open

cmd/link: support internal linking for Android and iOS #31819

eliasnaur opened this issue May 3, 2019 · 2 comments
Labels
mobile NeedsInvestigation

Comments

@eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented May 3, 2019

We're about to run self-hosted Android and iOS builders (#31722). It would be nice if Go could produce internally linked binaries for those platforms, for a less hacky bootstrapping and for being able to build x/build/cmd/buildlet and stage0 everywhere. Depends on #31343 Android.
@katiehockman katiehockman added mobile NeedsInvestigation labels May 3, 2019
@katiehockman
Copy link
Contributor

@katiehockman katiehockman commented May 3, 2019

/cc @cherrymui @ianlancetaylor

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 15, 2019

Change https://golang.org/cl/207299 mentions this issue: cmd/link: bootstrap android/arm64 in internal linking mode

gopherbot pushed a commit that referenced this issue Feb 26, 2020
@eliasnaur
cmd/link: default to internal linking for android/arm64
e6d7326 
The bootstrapping process (make.bash) on all other platforms use
internal linking. This change brings android/arm64 in line, fixing the
scary warning on our self-hosted Corellium builders:

warning: unable to find runtime/cgo.a

The linkmode default is changed to internal for all Android programs,
but in practice that won't matter outside our builders: using Go with
Android apps requires buildmode=c-shared which uses linkmode external.

Fixes #31343
Updates #31819

Change-Id: I3b3ada5ed69a7989e6d8e5960bbebf5e1c22aada
Reviewed-on: https://go-review.googlesource.com/c/go/+/207299
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mobile NeedsInvestigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eliasnaur @gopherbot @katiehockman