Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/ed25519: reject low order points #31846

Open
FiloSottile opened this issue May 5, 2019 · 2 comments
Open

crypto/ed25519: reject low order points #31846

FiloSottile opened this issue May 5, 2019 · 2 comments
Assignees
Milestone

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented May 5, 2019

Rejecting low order points is not strictly necessary, but it helps root out behaviors that can come unexpected to protocol designers (like non-contributory DH, or signature:message:key not being 1:1:1). libsodium already does indiscriminately, and we should too.

https://github.com/jedisct1/libsodium/blob/cec56d867f741e66f78b9fde37d9081643599a2a/src/libsodium/crypto_scalarmult/curve25519/ref10/x25519_ref10.c#L90

This was suggested by Cas Cremers and Dennis Jackson as part of their upcoming work on revisiting small subgroup and invalid curve attacks.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 19, 2019

Change https://golang.org/cl/183039 mentions this issue: crypto/tls: reject low-order Curve25519 points

gopherbot pushed a commit that referenced this issue Jun 20, 2019
The RFC recommends checking the X25519 output to ensure it's not the
zero value, to guard against peers trying to remove contributory
behavior.

In TLS there should be enough transcript involvement to mitigate any
attack, and the RSA key exchange would suffer from the same issues by
design, so not proposing a backport.

See #31846

Change-Id: I8e657f8ee8aa72c3f8ca3b124555202638c53f5e
Reviewed-on: https://go-review.googlesource.com/c/go/+/183039
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@FiloSottile FiloSottile changed the title x/crypto/curve25519,x/crypto/ed25519: reject low order points crypto/ed25519: reject low order points Oct 1, 2019
@FiloSottile

This comment has been minimized.

Copy link
Member Author

@FiloSottile FiloSottile commented Oct 1, 2019

Curve25519 is covered by #32670, this issue is now about doing the check in crypto/ed25519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.