Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: allow ListenAndServeTLS to omit PEM file values if TLSConfig.GetConfigForClient set #31855

Open
TheTesla opened this issue May 6, 2019 · 2 comments
Labels
Milestone

Comments

@TheTesla
Copy link

@TheTesla TheTesla commented May 6, 2019

If I set GetConfigForClient and start the server using ListenAndServeTLS the arguments of ListenAndServeTLS, the server certificate and its key are lneeded to be given and they are also loaded. I have set the server certificate and its key in the configuration TLSConfig served by GetConfigForClient before. So using GetConfigForClient ListenAndServeTLS should ignore its arguments and they should also be optional.

@gopherbot
Copy link

@gopherbot gopherbot commented May 6, 2019

Change https://golang.org/cl/175457 mentions this issue: GetConfigForClient replaces cert and key arguments

@bradfitz bradfitz changed the title [feature] setting GetConfigForClient ignore ListenAndServeTLS arguments net/http: allow ListenAndServeTLS to omit PEM file values if TLSConfig.GetConfigForClient set May 7, 2019
@bradfitz bradfitz added this to the Go1.14 milestone May 7, 2019
@bradfitz bradfitz added the NeedsFix label May 7, 2019
@mikedanese
Copy link
Contributor

@mikedanese mikedanese commented Jul 4, 2019

What config should be used if the client doesn't send a hello?

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.