Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: allow ListenAndServeTLS to omit PEM file values if TLSConfig.GetConfigForClient set #31855
Comments
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
May 6, 2019
|
Change https://golang.org/cl/175457 mentions this issue: |
bradfitz
changed the title
[feature] setting GetConfigForClient ignore ListenAndServeTLS arguments
net/http: allow ListenAndServeTLS to omit PEM file values if TLSConfig.GetConfigForClient set
May 7, 2019
bradfitz
added this to the Go1.14 milestone
May 7, 2019
bradfitz
added
the
NeedsFix
label
May 7, 2019
This comment has been minimized.
This comment has been minimized.
|
What config should be used if the client doesn't send a hello? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TheTesla commentedMay 6, 2019
If I set GetConfigForClient and start the server using ListenAndServeTLS the arguments of ListenAndServeTLS, the server certificate and its key are lneeded to be given and they are also loaded. I have set the server certificate and its key in the configuration TLSConfig served by GetConfigForClient before. So using GetConfigForClient ListenAndServeTLS should ignore its arguments and they should also be optional.