Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: help should print only to stdout #31885

Closed
rsc opened this issue May 7, 2019 · 3 comments
Closed

cmd/vet: help should print only to stdout #31885

rsc opened this issue May 7, 2019 · 3 comments

Comments

@rsc
Copy link
Contributor

@rsc rsc commented May 7, 2019

go tool vet help prints half its output to stdout and half to stderr. All output should go to one place, and that place is stdout.

/cc @matloob @ianthehat

@rsc rsc added this to the Go1.13 milestone May 7, 2019
@rsc rsc added the release-blocker label May 7, 2019
@dmitshur dmitshur added the NeedsFix label May 7, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented May 9, 2019

Change https://golang.org/cl/175900 mentions this issue: cmd/vet: print help to stdout only

@ysmolsky

This comment has been minimized.

Copy link
Member

@ysmolsky ysmolsky commented May 9, 2019

Also we need to vendor-in the changed code to really fix the issue.

gopherbot pushed a commit to golang/tools that referenced this issue May 10, 2019
Previously help for flags was printed to stderr.
This CL makes all the output to be printed to stdout.

Updates golang/go#31885

Change-Id: If95edeccd79581326502dd5c7fc2b49d8f160be7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/175900
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented May 10, 2019

Change https://golang.org/cl/176617 mentions this issue: cmd/vendor: import vet fixes from x/tools

@gopherbot gopherbot closed this in 5833aa5 May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.