Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: downloads follow plain-HTTP redirects even when the -insecure flag is not set [1.12 backport] #31887

Open
bcmills opened this issue May 7, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@bcmills
Copy link
Member

commented May 7, 2019

Per #29618 (comment):

I've been thinking about this some more. I don't think we'll have adequate soak time on the change until after Go 1.13 is released: I suspect that the problems will be in the long tail of packages, and users on the long tail by and large are not testing against HEAD on a nightly basis.

While this is a security issue, I don't think it's major enough to risk breaking long-tail packages at a point release.

I'm going to tentatively schedule the 1.12 backport for a couple of weeks after the 1.13 release, when we'll have a clearer view of just how broken the long tail is.

@bcmills bcmills added this to the Go1.12.6 milestone May 7, 2019

@dmitshur

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

I'm going to tentatively schedule the 1.12 backport for a couple of weeks after the 1.13 release, when we'll have a clearer view of just how broken the long tail is.

@bcmills Can you clarify what you meant by "a couple of weeks after the 1.13 release"? After the final 1.13 release (as in "v1.13.0" in semver form), or something else? If so, we should move this to a later 1.12.x milestone.

@bcmills bcmills modified the milestones: Go1.12.6, Go1.12.7 Jun 7, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

After the final 1.13 release. I want folks to be able to go back to a supported 1.12 release as a mitigation if they discover a secure-to-insecure redirect when moving to 1.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.