Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support autocompletion of unimported packages #31906

Open
stamblerre opened this issue May 8, 2019 · 7 comments

Comments

Projects
None yet
6 participants
@stamblerre
Copy link
Contributor

commented May 8, 2019

See for microsoft/vscode-go#2484 for context.

@ramya-rao-a

This comment has been minimized.

Copy link

commented May 9, 2019

When this does get into gopls please send a PR or log an issue to the vscode Go plugin so that we can disable the similar feature (in non module mode) there to avoid duplicate suggestions

@zchee

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@stamblerre
Just a question.
Is this issue means only of stdlib like gocode?
Or, all of packages ingo.mod?

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

It would be all available packages, not just stdlib.

@zchee

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@stamblerre
great.

Are you doing now develop this feature?
I do not know what you remember to me, but I maintained nsf/gocode for a while. If you not yet develop this feature, I would want to help you.

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

I am not actively working on it yet, so you're absolutely welcome to get started on it.

@jackielii

This comment has been minimized.

Copy link

commented Jun 12, 2019

@stamblerre @saibing I found out that this is a difference between https://github.com/saibing/tools & https://github.com/golang/tools/tree/ : saibing/tools already have this feature:

image
screenshot from saibing/tools + coc.nvim + neovim nightly build

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

From microsoft/vscode-go#2575:

There are really two components to this issue. For example (in both cases, time is not imported):

  1. Typing "ti<>" and getting package time as part of the autocompletion results.
  2. Typing "time.<>" and getting autocompletions for the members of package time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.