Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: schedule: holding locks (js/wasm) #31939

Closed
bradfitz opened this issue May 9, 2019 · 3 comments
Closed

runtime: schedule: holding locks (js/wasm) #31939

bradfitz opened this issue May 9, 2019 · 3 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 9, 2019

js/wasm flake:

https://build.golang.org/log/b658c5bb1f30be3368ddd4b4a6a218b582769d2c

##### ../test
# go run run.go -- heapsampling.go
exit status 1
fatal error: schedule: holding locks

runtime stack:
runtime.throw(0x394a5, 0x17)
	/workdir/go/src/runtime/panic.go:714 +0x7
runtime.schedule()
	/workdir/go/src/runtime/proc.go:2465 +0x90
runtime.goschedImpl(0x400780)
	/workdir/go/src/runtime/proc.go:2626 +0x30
runtime.gosched_m(0x400780)
	/workdir/go/src/runtime/proc.go:2634 +0x3
runtime.mcall(0x169cb0)
	/workdir/go/src/runtime/asm_wasm.s:104 +0x1

goroutine 1 [wait for GC cycle]:
runtime.GC()
	/workdir/go/src/runtime/mgc.go:1067 +0x5
main.getMemProfileRecords(0x186a0, 0x1, 0x1)
	/workdir/go/test/heapsampling.go:222 +0x2
main.testInterleavedAllocations(0x1, 0x152a0)
	/workdir/go/test/heapsampling.go:55 +0x6
main.main()
	/workdir/go/test/heapsampling.go:33 +0x2
exit status 2

FAIL	heapsampling.go	10.247s

/cc @aclements @neelance

@bradfitz bradfitz added this to the Go1.13 milestone May 9, 2019
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented May 9, 2019

Presumably fixed by cd03664, @mknyszek?

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented May 9, 2019

Yes, but we should still probably wait to see what the bot says before we close it.

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented May 9, 2019

OK bot looks good.

@mknyszek mknyszek closed this May 9, 2019
@golang golang locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.