Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/cover_pkgall_multiple_mains broken at head #31963

Closed
bcmills opened this issue May 10, 2019 · 2 comments
Closed

cmd/go: TestScript/cover_pkgall_multiple_mains broken at head #31963

bcmills opened this issue May 10, 2019 · 2 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented May 10, 2019

It's not clear to me when it regressed; it was masked in the dashboard by #31263. 馃槥

I'll try bisecting.

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/cover_pkgall_multiple_mains (14.06s)
        script_test.go:192: 
            # This test checks that multiple main packages can be tested
            # with -coverpkg=all without duplicate symbol errors.
            # Verifies golang.org/issue/30374. (14.057s)
            > env GO111MODULE=on
            > [short] skip
            > go test -coverpkg=all ./...
            [stdout]
            ?   	example.com/cov/mainonly	[no test files]
            FAIL	example.com/cov/mainwithtest [build failed]
            FAIL	example.com/cov/xtest [build failed]
            [stderr]
            # example.com/cov/xtest.test
            2019/05/10 14:46:08 duplicate symbol main.main (types 1 and 1) in main and $WORK/b059/_pkg_.a(_go_.o)
            # example.com/cov/mainwithtest.test
            2019/05/10 14:46:08 duplicate symbol main.main (types 1 and 1) in main and $WORK/b054/_pkg_.a(_go_.o)
            [exit status 2]
            FAIL: testdata/script/cover_pkgall_multiple_mains.txt:9: unexpected command failure
            
FAIL

CC @jayconrod

@bcmills bcmills self-assigned this May 10, 2019
@bcmills bcmills added this to the Go1.13 milestone May 10, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented May 10, 2019

git bisect points to CL 174657 (CC @cherrymui @aclements @rsc).

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented May 10, 2019

Duplicate of #31946

@bcmills bcmills marked this as a duplicate of #31946 May 10, 2019
@bcmills bcmills closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.