Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/signal: TestCtrlBreak broken on windows-amd64-2012 builder #31968

Closed
bcmills opened this issue May 10, 2019 · 1 comment
Closed

os/signal: TestCtrlBreak broken on windows-amd64-2012 builder #31968

bcmills opened this issue May 10, 2019 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented May 10, 2019

See also #29744.

First failure is in https://build.golang.org/log/94dadf4ba4fca2f4a0de5d3c6230ad744c1286f8, at CL 176106 (CC @rsc @aclements @bradfitz).

The CL appears to be related, in that it's touching Windows assembly routines in the runtime.

--- FAIL: TestCtrlBreak (1.66s)
    signal_windows_test.go:102: Program exited with error: exit status 3221225786
FAIL
FAIL	os/signal	1.742s
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels May 10, 2019
@bcmills bcmills added this to the Go1.13 milestone May 10, 2019
@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

Fixed in https://golang.org/cl/176557.

@bcmills bcmills closed this as completed May 10, 2019
@golang golang locked and limited conversation to collaborators May 9, 2020
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@rsc @bcmills @gopherbot