Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: non-100%-reproducible object files #31975

Closed
josharian opened this issue May 10, 2019 · 3 comments
Closed

cmd/compile: non-100%-reproducible object files #31975

josharian opened this issue May 10, 2019 · 3 comments

Comments

@josharian
Copy link
Contributor

@josharian josharian commented May 10, 2019

Observed by @dr2chase in CL 176577. I have reproduced locally using for f in seq 1000; do go build -o oserr -a internal/oserror; md5 oserr; done and noting occasional deviations.

I am bisecting now.

@josharian

This comment has been minimized.

Copy link
Contributor Author

@josharian josharian commented May 11, 2019

Drat. Bisected to https://go-review.googlesource.com/c/go/+/170037, which was just when non-trivial code was added to internal/oserror. Will bisect again tomorrow.

@cuonglm

This comment has been minimized.

Copy link
Contributor

@cuonglm cuonglm commented May 11, 2019

@josharian Because https://go-review.googlesource.com/c/go/+/170037 added duplicated anonymous interface, causing build not 100% reproducible.

CL https://go-review.googlesource.com/c/go/+/162240/ tries to fix that problem, +2 but not merge yet.

@josharian

This comment has been minimized.

Copy link
Contributor Author

@josharian josharian commented May 11, 2019

Looks like this is indeed a duplicate of #30202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.