Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/internal/obj/x86: TestOclass/386 broken on solaris-amd64-smartosbuildlet #32028

Closed
bcmills opened this issue May 14, 2019 · 2 comments
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented May 14, 2019

The test fails consistently. An example run (https://build.golang.org/log/5a4d651e6c0f6c765aadbfaed8ea393096f71e63):

--- FAIL: TestOclass (0.00s)
    --- FAIL: TestOclass/386 (0.00s)
        asm_test.go:205: oclass("$(SB)"):
            have: 11
            want: 9
FAIL
FAIL	cmd/internal/obj/x86	2.286s

This test was added in CL 175357 and has been failing ever since (CC @quasilyte @cherrymui @TocarIP).

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Solaris NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels May 14, 2019
@bcmills bcmills added this to the Go1.13 milestone May 14, 2019
@quasilyte
Copy link
Contributor

I'll fix it in a few mins.

@gopherbot
Copy link

Change https://golang.org/cl/177077 mentions this issue: cmd/internal/obj/x86: fix oclass tests for Hsolaris

@golang golang locked and limited conversation to collaborators May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants