Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/crypto/ssh: performance issues after #24942 was fixed #32034
And this discussion:
But I just wanted to express what I have been seeing happening with this change affecting performance on an SSH connection.
What version of Go are you using (
this looks like an issue in the networking code. You could run with debugHandshake to see what is going on .
I would also suggest to remove the keepalive stuff. SSH has its own keepalive mechanism which would be preferable. Just do like here:
@hanwen yes it seems that the TCP keep alive we were using was the culprit for some reason hanging up on the SSH side, when we dont see the same issue on other TCP connections. I am able to connect quickly on 1.12.5 now with the keepalive code taken out.
I also added your keepalive in its place and hoping it keeps the connections open for most devices
Thank you very much for your help @hanwen, you did your good deed for the day! Now go get a beer on me! ;-)
I wish I just understood why that non-blocking commit conflicted with the github.com/felixge/tcpkeepalive package on SSH. A lot of this stuff is new territory for me personally. I did set debugHandshake and I will use that in the future for any SSH related packet issues, that is a very helpful logging flag to set when you have to debug a connection handshake.