Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: inlining mark elimination is fragile #32069
[broken out from #32068]
If you remove the following rule from generic.rules
and recompile math/cmplx.Inf, you get similar generated code. The constant folding that did not occur during generic opt occurs in lowered opt. (The generated code isn't identical, but I'm working on that independently.)
However, if the constant folding occurs during lowered opt, there is no inlining nop at the beginning of the function.
Either we need one, or we don't; it shouldn't be sensitive to whether a particular generic constant folding optimization occurs.
cc @randall77 for inlining marks