Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: make it clear that implementation is compliant with RFC 5246 #32079

Open
ALTree opened this issue May 16, 2019 · 1 comment
Open
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ALTree
Copy link
Member

ALTree commented May 16, 2019

In #31933, @swanandt pointed out that the following note at the top of the crypto/tls package:

Package tls partially implements TLS 1.2, as specified in RFC 5246

may be misinterpreted as a warning about non-compliance with the RFC 5246. This is not the case, as @FiloSottile explained:

As far as I know, we implement everything that is REQUIRED by RFC 5246, so we are in full compliance with it.

It may be useful to slightly change the wording of the doc to make it completely clear the only optional features (like DHE, topic of the discussion at #31933) are currently not implemented, and so the package is fully compliant with RFC 5246.

@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label May 17, 2019
@FiloSottile FiloSottile added this to the Unplanned milestone May 17, 2019
@gopherbot
Copy link

gopherbot commented May 18, 2019

Change https://golang.org/cl/177898 mentions this issue: crypto/tls: clarify that all required features of TLS are supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants