Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: TestVerifyHostnameResumed failing on longtest builder #32090

Closed
bradfitz opened this issue May 16, 2019 · 4 comments
Closed

crypto/tls: TestVerifyHostnameResumed failing on longtest builder #32090

bradfitz opened this issue May 16, 2019 · 4 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 16, 2019

https://build.golang.org/log/1eff95520436e93eb2b0adee96417c7776dc6384

--- FAIL: TestVerifyHostnameResumed (1.53s)
    --- FAIL: TestVerifyHostnameResumed/TLSv13 (0.51s)
        tls_test.go:381: Subsequent connection unexpectedly didn't resume
FAIL
FAIL	crypto/tls	2.430s

It started at seemingly unrelated https://go-review.googlesource.com/c/go/+/176925 (cmd/go) and persisted the following three commits.

Does this test depend on the network? Did some peer change its behavior?

@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented May 17, 2019

Yeah the GFEs started bundling session tickets with the first flight, I think. Sent a fix.

@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented May 17, 2019

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented May 17, 2019

Change https://golang.org/cl/177877 mentions this issue: crypto/tls: fix TestVerifyHostnameResumed

@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented May 17, 2019

remote: The push has been rejected because we detect that it contains a private
remote: key. Please check the following commands and confirm that it's
remote: intentional:

https://go-review.googlesource.com/c/go/+/177877

@gopherbot gopherbot closed this in e22e2b3 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.