Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/shiny/driver/gldriver: add missing modifier key codes #32131

Closed
smasher164 opened this issue May 18, 2019 · 3 comments

Comments

@smasher164
Copy link
Member

commented May 18, 2019

Currently the right control key and right command keys are not (accurately) represented in the mods struct. After testing for key events, I've determined that

  • key.ControlRight should be represented by the flags 33<<13 | 0x100, the code C.kVK_RightControl, and modifier key.ModControl.
  • kVK_RightCommand should be represented by the flags 1<<20 | 0x110, the code 0x36 (does not appear in Events.h), and modifier key.ModMeta.

@gopherbot gopherbot added this to the Unreleased milestone May 18, 2019

@smasher164

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

Is there something in particular that needs investigating? The items I mentioned are currently TODOs in shiny/driver/gldriver/cocoa.go. I understand if there is a bandwidth issue with having to review shiny code. I can submit a CL that makes the above changes if desired.

@gopherbot

This comment has been minimized.

Copy link

commented Jul 31, 2019

Change https://golang.org/cl/188378 mentions this issue: shiny/driver/gldriver: add missing modifier key codes on cocoa

@dmitshur

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Is there something in particular that needs investigating?

It's just the very first triage state an issue goes through. See https://golang.org/wiki/HandlingIssues#issue-states for more information.

Thanks for reporting and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.