x/exp/shiny/driver/gldriver: add missing modifier key codes

[smasher164]

Currently the right control key and right command keys are not (accurately) represented in the mods struct. After testing for key events, I've determined that

• key.ControlRight should be represented by the flags 33<<13 | 0x100, the code C.kVK_RightControl, and modifier key.ModControl.
• kVK_RightCommand should be represented by the flags 1<<20 | 0x110, the code 0x36 (does not appear in Events.h), and modifier key.ModMeta.

[smasher164]

Is there something in particular that needs investigating? The items I mentioned are currently TODOs in shiny/driver/gldriver/cocoa.go. I understand if there is a bandwidth issue with having to review shiny code. I can submit a CL that makes the above changes if desired.

[gopherbot]

Change https://golang.org/cl/188378 mentions this issue: shiny/driver/gldriver: add missing modifier key codes on cocoa

[dmitshur]

Is there something in particular that needs investigating?

It's just the very first triage state an issue goes through. See https://golang.org/wiki/HandlingIssues#issue-states for more information.

Thanks for reporting and fixing this!