Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: changing package names returns an error #32149

Open
ianthehat opened this issue May 20, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@ianthehat
Copy link

commented May 20, 2019

Originally reported in microsoft/vscode-go#2520

If you edit the package name, something in the caching causes persistent errors until a gopls restart.

@ianthehat ianthehat added the gopls label May 20, 2019

@ianthehat ianthehat self-assigned this May 20, 2019

@stamblerre stamblerre changed the title gopls: Changing package names causes LSP to return error x/tools/cmd/gopls: changing package names returns an error May 20, 2019

@gopherbot gopherbot added this to the Unreleased milestone May 20, 2019

@gopherbot

This comment has been minimized.

Copy link

commented May 21, 2019

Change https://golang.org/cl/178162 mentions this issue: internal/lsp: re-run go/packages.Load when the package name changes

@stamblerre

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Re-opening because this doesn't work if you don't save the file. I imagine that's likely because go/packages needs to be looking at the overlay for the package name, but I'm not certain.

@stamblerre

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

/cc @matloob

@stamblerre stamblerre changed the title x/tools/cmd/gopls: changing package names returns an error x/tools/gopls: changing package names returns an error Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.