Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/analysis: running the same analysis with different sets of flags #32155

Open
dominikh opened this issue May 21, 2019 · 1 comment
Open
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@dominikh
Copy link
Member

By convention, analyses are provided as singletons in package variables, a la var Analysis = &analysis.Analyzer{...}. Furthermore, analysis.Analyzer stores a flag.FlagSet for providing options to the analysis. However, this combination of singleton and FlagSet makes it difficult to run one analysis multiple times concurrently with different options. This becomes especially problematic when multiple independent tools coexist in the same address space and want to use the same analysis with different options, as they won't be coordinating with each other.

As far as I am aware, there is no suitable workaround.

/cc @matloob

@dominikh dominikh added this to the Unreleased milestone May 21, 2019
@bcmills
Copy link
Member

bcmills commented May 21, 2019

CC @ianthehat

@bcmills bcmills added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 21, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@adonovan adonovan added the Analysis Issues related to static analysis (vet, x/tools/go/analysis) label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants