Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: provide portrait screen mode friendly style for mobile devices #32183

Open
hyangah opened this issue May 22, 2019 · 3 comments
Open

x/website: provide portrait screen mode friendly style for mobile devices #32183

hyangah opened this issue May 22, 2019 · 3 comments

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented May 22, 2019

Browse https://tip.golang.org/cmd/go
from mobile devices, on portrait mode

Particularly the two column TOC is not ideal.

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

Chrome on android

@agnivade
Copy link
Contributor

@agnivade agnivade commented May 22, 2019

I had done some work (CL 129135) to generate the TOC at server side for the /search page. For the rest of the pages, AFAIR, the TOC is hard-coded to be 2 columns. Is this issue just about adjusting the no. of columns in TOC for mobile devices or are there other aspects to be tacked ?

@andybons @dmitshur - Is the TOC rendering logic going to be looked at in the new website revamp ?

@andybons andybons changed the title doc: provide portrait screen mode friendly style for mobile devices x/website: provide portrait screen mode friendly style for mobile devices May 22, 2019
@gopherbot gopherbot added this to the Unreleased milestone May 22, 2019
@andybons
Copy link
Member

@andybons andybons commented May 22, 2019

@agnivade yes it’s likely we’ll look at it at some point.

@hyangah
Copy link
Contributor Author

@hyangah hyangah commented May 22, 2019

@agnivade I think switching to the single column mode when the width is not sufficient is sufficient for this bug.

I wished we could do something about the pre-formatted text width too but I guess I can live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.