Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: error output inserts "# play" line with multi-file programs #32237

Open
cosmonawt opened this issue May 24, 2019 · 5 comments
Open

x/playground: error output inserts "# play" line with multi-file programs #32237

cosmonawt opened this issue May 24, 2019 · 5 comments

Comments

@cosmonawt
Copy link

@cosmonawt cosmonawt commented May 24, 2019

What version of Go are you using (go version)?

go1.12.5

Does this issue reproduce with the latest release?

Did not test yet.

What operating system and processor architecture are you using (go env)?

play.golang.org

What did you do?

While working on a fix for #32064 I noticed that compile errors are prepended with # play.
Bildschirmfoto 2019-05-24 um 23 23 54

Example

What did you expect to see?

There should be no # play before the error output.

What did you see instead?

# play before the first line of error output.

@gopherbot gopherbot added this to the Unreleased milestone May 24, 2019
@cosmonawt

This comment has been minimized.

Copy link
Author

@cosmonawt cosmonawt commented May 24, 2019

This seems to be another instance of what is already happening and being treated in sandbox.go:388 to me.

Edit:
Also, it only happens when the file is named anything but prog.go:
foo.go
prog.go

@cosmonawt cosmonawt changed the title x/playgound: error output prepends # play with multi-file programs x/playground: error output prepends # play with multi-file programs May 24, 2019
@robpike robpike changed the title x/playground: error output prepends # play with multi-file programs x/playground: error output inserts "# play" line with multi-file programs May 25, 2019
@julieqiu

This comment has been minimized.

Copy link

@julieqiu julieqiu commented May 28, 2019

@julieqiu julieqiu modified the milestones: Unreleased, Go1.13 May 28, 2019
@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented May 28, 2019

@julieqiu, do you feel strongly that this is Go 1.13 thing? We can update the playground whenever and it's not tied to the Go release process or repo, which is why gopherbot added the Unreleased milestone.

@julieqiu julieqiu modified the milestones: Go1.13, Unreleased May 28, 2019
@julieqiu

This comment has been minimized.

Copy link

@julieqiu julieqiu commented May 28, 2019

I do not - I added the milestone because I assumed this is something that we would resolve by Go 1.13. Changed it back to Unreleased.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 2, 2019

Change https://golang.org/cl/180117 mentions this issue: playground: support error line highlighting for multi-file program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.