Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
net/http: improve useFakeNetwork check to allow browsers to run tests in wasm #32289
What version of Go are you using (
Actually, I can't recall why the 2nd version was changed. The only difference between 2nd and 3rd is that from catching all node-spawned processes, now it catches all tests under js,wasm flag.
len(os.Args) > 0 && path.Base(os.Args) == "node" && strings.HasSuffix(os.Args, ".test")
sounds better ? Since it filters both node processes and tests, allowing browser tests to run.
I meant what exactly changed in the logic from v2 to v3 to allow trybots to pass. AFAIU, v3 generalizes the logic to follow a non-wasm path for all tests. But v2 already allowed node. So how did it fail ? (assuming wasm trybots failed)
Anyways, I am afk at the moment, but I will check if my suggestion passes both node and browser tests.